Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 quote sqlv8 values #1479

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

dhensby
Copy link
Collaborator

@dhensby dhensby commented Mar 16, 2023

What this does:

This quotes generic arguments for the constructed connection string that is passed to msnodesqlv8; previous special chars in fields like password could end up breaking the connection string.

Related issues:

Fixes #1476

Pre/Post merge checklist:

  • Update change log

abhku
abhku previously approved these changes Mar 20, 2023
@dhensby dhensby merged commit fdf7b17 into tediousjs:master Aug 8, 2023
30 checks passed
@dhensby dhensby deleted the pulls/sqlv8-escape branch August 8, 2023 05:14
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

🎉 This PR is included in version 9.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in connecting to database when using msnodesqlv8 driver and password has special character in it
2 participants